Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility for SQL Server 2019 v15 #213

Open
wants to merge 1 commit into
base: azure-2.1
Choose a base branch
from
Open

Add compatibility for SQL Server 2019 v15 #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sql_server/pyodbc/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ class DatabaseWrapper(BaseDatabaseWrapper):
12: 2014,
13: 2016,
14: 2017,
15: 2017,
Copy link

@daybarr daybarr Jan 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be

        15: 2019,

2019 not 2017 ;)

But ... this project is no longer being maintained, and you should probably consider switching to https://github.com/FlipperPA/django-mssql-backend which has forked this project, landed the recent suggested improvements here, and is working to get mssql support into Django core. I've ported your PR over to that project (which also needs the change) in FlipperPA/django#13 . Thanks

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, I got confused. As noted here FlipperPA has actually endorsed the https://github.com/ESSolutions/django-mssql-backend fork which is putting out packages and supports Django 3 now.

I've ported your PR over to that project instead, which is what I should have done in the first place sorry. ESSolutions#32

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

}

# https://azure.microsoft.com/en-us/documentation/articles/sql-database-develop-csharp-retry-windows/
Expand Down