Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ulid support #127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: ulid support #127

wants to merge 1 commit into from

Conversation

atymic
Copy link
Contributor

@atymic atymic commented Sep 13, 2023

  • Add additional trait and route binding for ulid
  • Restructure test to support both uuid/ulid
  • Add tests for ulid to match UUID

Todo

  • Update Docs
  • Efficient Uuid Package needs to support ULIDs?

@atymic atymic mentioned this pull request Sep 13, 2023
Open
@michaeldyrynda
Copy link
Owner

michaeldyrynda commented Sep 16, 2023 •
edited
Loading

I think I’m going to merge the efficient uuid package into this one, release a new major, and EOL the other.

I have no end of trouble with the interdependency between the two, and given the functionality in the other package is optional I think it’s ok to combine it.

@atymic
Copy link
Contributor Author

atymic commented Sep 16, 2023

Agreed. Let me know if you need a hand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atymic @michaeldyrynda