Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to phpstan 2.0 #319

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

update to phpstan 2.0 #319

wants to merge 7 commits into from

Conversation

ptmkenny
Copy link

Fixes #318

Bumps the minimum PHP to 8.1 because that is what PHPStan 2 requires.

@ptmkenny
Copy link
Author

The problem with these test failures is that the new CircleCI images (since 2021) use ubuntu, not debian, so some of the scripts break.

So I tried to use the "legacy" images to stay with debian, but the last version of PHP supported is 8.0 (https://hub.docker.com/r/circleci/php/tags?ordering=last_updated&name=8.&page=35), there is no 8.1 image. And PHP 8.1 is required for PHPStan 2.0. So I guess all the CI stuff has to be reworked for ubuntu now.

Copy link
Owner

@mglaman mglaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this break as it conflicts with drupal/core-dev? So we should allow ^1 || ^2?

@ptmkenny ptmkenny marked this pull request as draft December 12, 2024 22:43
@ptmkenny
Copy link
Author

Won't this break as it conflicts with drupal/core-dev? So we should allow ^1 || ^2?

Work to update drupal/core-dev is here: https://www.drupal.org/project/drupal/issues/3486713

It makes sense to postpone this until core makes a decision on whether it will jump to phpstan 2 or allow 1 and 2.

@mglaman
Copy link
Owner

mglaman commented Dec 12, 2024

10.x, 11.0.x, and 11.1.x will at least support it. Although I don't think there's actually any fixes this project could get. But that's ~2 years until PHPStan 1.x isn't used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to PHPStan 2.x
2 participants