Use pytest as a test runner #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is very unfortunate that I need to use pytest -s to run the tests. I was unable to find a way of avoiding that. I haven't found a way of using a custom doctest checker with pytest either. The test suite might be completely broken on Windows. This is why I'm pushing to a branch.
Wow this was hard. So: 1. Our code doesn't really handle pathlib.Path objects on sys.path, so the scanning-inside-.zip-file was not being handled. I'm not sure why there were no failures, other than the coverage numbers. 2. Let's avoid importing Python 2 only modules like cPickle or cStringIO or email.Message; again I'm not sure why there were no errors about these names not existing. 3. Finally, the 'does a file exist on sys.path' was being exercised while looking for email/message.py before, but now something in pytest or coverage imports email.message, so it's found in sys.path, which short-circuits my isModule() check. I picked curses.panel instead, as something unlikely to be imported by the test runner.
I don't have high hopes for this approach, but why not try it?
|
Blocked on pytest-dev/pytest#13003, unless I can come up with some alternative solution (like rewriting the entire test suite from scratch). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very unfortunate that I need to use pytest -s to run the tests. I was unable to find a way of avoiding that.
I haven't found a way of using a custom doctest checker with pytest either. The test suite might be completely broken on Windows. This is why I'm pushing to a branch.