Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBS-13564: Correctly override primary on alias locale change #3398

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

MBS-13564: Correctly override primary on alias locale change #3398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b36b29a
MBS-13564: Correctly override primary on alias locale change
reosarevok Oct 30, 2024
8c32603
Split and document Data::Alias test
reosarevok Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions lib/MusicBrainz/Server/Data/Alias.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,12 +285,19 @@ sub update

# Clear existing primary for locale flag for the chosen locale
# if we are overriding them (the user chose this as primary)
if ($row{primary_for_locale}) {
# We need to load the alias because %row only contains changed values
# We need to check if either primary or the locale changed
# and then load the alias because %row only contains changed values
if ($row{primary_for_locale} || $row{locale}) {
my $alias = $self->get_by_id($alias_id);
my $locale = $row{locale} // $alias->{locale};
my $primary_for_locale = $row{primary_for_locale} // $alias->{primary_for_locale};
my $entity_id = $alias->{$type . '_id'};
$self->clear_primary_for_locale($locale, $entity_id);
# Whether we just set primary or it was already set and we
# are keeping it while changing the locale, we need to clear
# the existing primary
if ($primary_for_locale) {
$self->clear_primary_for_locale($locale, $entity_id);
}
}

add_partial_date_to_row(\%row, $alias_hash->{begin_date}, 'begin_date')
Expand Down
Loading