CB-410: Revisions of reviews are created when drafts are made, and they remain visible #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At a quick look, these changes need to be made for the api as well? |
amCap1712
reviewed
Sep 28, 2022
| @@ -374,3 +375,32 @@ def test_hide_redirect(self): | |||
| review["entity_type"], review["entity_id"])) | |||
| redirect_url = urlparse(response.location) | |||
| self.assertEqual(redirect_url.path, url_for('review.entity', id=review['id'])) | |||
|
|
|||
|
|
|||
| def test_publish_draft_review(self): | |||
There was a problem hiding this comment.
Since we are deleting data, this test should be more comprehensive IMO. Probably fetch the actual revisions before publish, assert, then fetch again after publish to confirm the correct revisions were deleted.
There was a problem hiding this comment.
Sounds Good! I've improved the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CB-410
This PR:
We need to run 2 queries in our database