Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]:Changing Upload and download artifact actions to v4 #690

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

[WIP]:Changing Upload and download artifact actions to v4 #690

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d16f96e
bump upload-arifact to v4
TusharMohapatra07 Dec 11, 2024
1b57426
append unique identifier run_id to artifact name to avoid duplication…
TusharMohapatra07 Dec 11, 2024
cd80130
change artifact name to be more self descriptive
TusharMohapatra07 Dec 11, 2024
23c70e9
bump download-artifact version to v4
TusharMohapatra07 Dec 11, 2024
c14fb05
change file name to data.json
TusharMohapatra07 Dec 11, 2024
a2bb5ec
add same patternfile name for upload and download artifacts
TusharMohapatra07 Dec 14, 2024
3d6bb3d
fix unexpected symbol issue
TusharMohapatra07 Dec 14, 2024
c8dc70a
add same path for corresponding upload artifact
TusharMohapatra07 Dec 14, 2024
c5d113f
Revert "fix unexpected symbol issue"
TusharMohapatra07 Dec 14, 2024
906a41a
remove path
TusharMohapatra07 Dec 14, 2024
f911ece
test: checking if this works
TusharMohapatra07 Dec 14, 2024
1438b19
test: checking if this works
TusharMohapatra07 Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions .github/workflows/e2etests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
yq e -i '.services.istio.version="${{ steps.gettag.outputs.release }}"' ./.github/install/deploy.yaml
cat ./.github/install/deploy.yaml
- name: Uploading file
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: patternfile
path: ./.github/install/deploy.yaml
Expand Down Expand Up @@ -83,9 +83,9 @@ jobs:
repository: meshery/meshery
token: ${{ secrets.GH_ACCESS_TOKEN }}
- name: DownloadJSON
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: data.json
name: patternfile
- name: Add commit SHORT_SHA
run: echo "SHORT_SHA=`echo ${GITHUB_SHA} | cut -c1-8`" >> $GITHUB_ENV
- name: echo results
Expand Down Expand Up @@ -155,9 +155,9 @@ jobs:
yq e -i '.services.prometheus.version="${{ steps.gettag.outputs.release }}"' ./.github/install/deploywithaddons.yaml
cat ./.github/install/deploywithaddons.yaml
- name: Uploading file
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: patternfile
name: patternfile-servicemesh-addon
path: ./.github/install/deploywithaddons.yaml

TestIstioForServicemeshAndAddon:
Expand Down Expand Up @@ -198,9 +198,9 @@ jobs:
repository: meshery/meshery
token: ${{ secrets.GH_ACCESS_TOKEN }}
- name: DownloadJSON
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: data.json
name: patternfile-servicemesh-addon
- name: Add commit SHORT_SHA
run: echo "SHORT_SHA=`echo ${GITHUB_SHA} | cut -c1-8`" >> $GITHUB_ENV
- name: echo results
Expand Down Expand Up @@ -270,9 +270,9 @@ jobs:
yq e -i '.services.istioinstallation.settings.istioVersion="${{ steps.gettag.outputs.release }}"' ./.github/install/deploywithsampleapp.yaml
cat ./.github/install/deploywithsampleapp.yaml
- name: Uploading file
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: patternfile
name: patternfile-servicemesh-sample-app
path: ./.github/install/deploywithsampleapp.yaml

TestIstioForServicemeshAndSampleApp:
Expand Down Expand Up @@ -313,9 +313,9 @@ jobs:
repository: meshery/meshery
token: ${{ secrets.GH_ACCESS_TOKEN }}
- name: DownloadJSON
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: data.json
name: patternfile-servicemesh-sample-app
- name: Add commit SHORT_SHA
run: echo "SHORT_SHA=`echo ${GITHUB_SHA} | cut -c1-8`" >> $GITHUB_ENV
- name: echo results
Expand Down