Comparison tool #249
Comparison tool #249
Conversation
kakoeh
force-pushed
the
comparison_tool
branch
from
7912c26 to
638e55a
Compare
kakoeh
force-pushed
the
comparison_tool
branch
3 times, most recently
from
b3343d5 to
b2340fe
Compare
kakoeh
force-pushed
the
comparison_tool
branch
from
b2340fe to
770373f
Compare
|
Where did the file |
pyproject.toml
Outdated
| @@ -42,6 +42,7 @@ dependencies = [ | |||
| "markdownify >= 0.11", | |||
| "deprecation >= 2.1", | |||
| "packaging", | |||
| "pandas >= 2.1.4" | |||
There was a problem hiding this comment.
pandas is a test dependency or library dependency?
There was a problem hiding this comment.
Where did the file
examples/somersault_01.01.02.pdxcome from?
The file was derived from the file somersault.pdx by adapting somersaultecu.py
pandas is a test dependency or library dependency?
pandas was used by several functions but has been replaced
There was a problem hiding this comment.
what are the adaptations?
@andlaus are you ok with adding a binary file without the logic that created it?
There was a problem hiding this comment.
- new ecu variant
somersault_young - deleted SingleEcuJob
compulsory_program - deleted DiagService
set_operation_params - new DiagService
flicflac - renamed DiagService
start_sessionfromsession_starttostart_session - changed list of request parameter of DiagService
headstand - changed pos. response parameter of
session_start
(DOP ofcan_do_backward_flipsfrombooleantouint8) - changed pos. response parameter of
tester_present
(value ofstatusfrom0x00to0x0043and type fromuint8touint16) - changed pos. response parameter of
grudging_backward
(byte position ofnum_flips_donefromNoneto1)
(param type ofgrumpiness_levelfromValueParametertoCodedConstParameter,
incl. byte position fromNoneto2, value =0x05) - changed pos. response parameter of
status_report
(byte position ofhappiness_levelfrom2to1)
(byte position ofdizzyness_levelfrom1to2) - changed request parameter of
stop_session
(type ofidfromuint8touint16) - changed request parameter of
tester_present
(value ofidfrom0x0to0x01) - changed request parameter of
do_backward_flips
(short_name ofbackward_checkfrombackward_soberness_checktobackward_check)
There was a problem hiding this comment.
@andlaus are you ok with adding a binary file without the logic that created it?
I suppose in this case it is okay, because that new file is basically a showcase for the compare tool. (I'd prefer to have a script doing these modifications in-repo, though.)
can this file be renamed to something which better conveys the fact that it is a modified version of the original, though? (something like somersault_modified.pdx.)
kakoeh
force-pushed
the
comparison_tool
branch
7 times, most recently
from
4ae03dc to
96837e1
Compare
kakoeh
force-pushed
the
comparison_tool
branch
from
96837e1 to
d44656f
Compare
- new cli tool 'compare' - new example pdx to test compare tool - added unittest for cli tool 'compare' Signed-off-by: Katja Köhler <[email protected]> Signed-off-by: Andreas Lauser <[email protected]>
kakoeh
force-pushed
the
comparison_tool
branch
from
d44656f to
d4dca14
Compare
|
nice, thanks all! |
New cli tool "compare" (odxtools - Issue 35)
Can be used to compare databases (pdx-files) and/or ecu variants with each other.
Compares all diagnostic services as well as its parameters of the specified databases /variants with each other and displays the changes.
Katja Köhler <[email protected]>, on behalf of MBition GmbH.
Provider Information