-
-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes: PWA & interface on small screens #2536
fixes: PWA & interface on small screens #2536
Conversation
Can you post some screenshots of these UI changes? |
These changes are lovely thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple changes need to be made, but overall looks good.
For the translations. You should only modify the english set of json files. The rest are auto-generated and PR is made by an external service, so those need to be changed as well.
This reverts commit 150a961.
Thank you for your feedback ! I made the modifications. For translations, I know that Mealie uses Crowdwin but the English-only strings are not present in the other languages interface. Is there a pipeline to launch? |
Thanks! The other languages should fallback if there's no reference. But once this is merged Crowdin will automatically fill those with defaults and then people can start translating them. I realized that the Crowdin integration has been broken for some time, so I wanted to get that fixed before I merged this. Thanks for your patience! Should be fixed today and then I'll merge this! |
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
This PR improves the PWA icons used on smartphone and disable the default icon generation with nuxt/pwa.
This also improves the readibility of actions buttons and fix spacing on small screens.
i18n : missing strings are added
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #2364
Release Notes
(REQUIRED)