Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes: PWA & interface on small screens #2536

Merged
merged 7 commits into from
Oct 7, 2023

Conversation

p0lycarpio
Copy link
Contributor

What type of PR is this?

(REQUIRED)

  • bug
  • cleanup

What this PR does / why we need it:

(REQUIRED)

This PR improves the PWA icons used on smartphone and disable the default icon generation with nuxt/pwa.
This also improves the readibility of actions buttons and fix spacing on small screens.

i18n : missing strings are added

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #2364

Release Notes

(REQUIRED)

improve PWA icons & UI on small screens
regenerate translation strings

@hay-kot
Copy link
Collaborator

hay-kot commented Sep 14, 2023

Can you post some screenshots of these UI changes?

@p0lycarpio
Copy link
Contributor Author

Here are some examples of interface changes on small screens.

Before / After

Login page

Recipe editing

User settings

same in group and other pages


PWA icons changes

warning and cropped maskable icons

Before
Capture d’écran du 2023-09-14 18-07-57
Capture d’écran du 2023-09-14 18-08-11

After
Capture d’écran du 2023-09-14 18-08-21
Capture d’écran du 2023-09-14 18-08-36

@hay-kot hay-kot enabled auto-merge (squash) September 15, 2023 17:06
@hay-kot
Copy link
Collaborator

hay-kot commented Sep 15, 2023

These changes are lovely thank you!

Copy link
Collaborator

@hay-kot hay-kot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple changes need to be made, but overall looks good.

For the translations. You should only modify the english set of json files. The rest are auto-generated and PR is made by an external service, so those need to be changed as well.

frontend/pages/admin/backups.vue Outdated Show resolved Hide resolved
frontend/pages/group/members.vue Outdated Show resolved Hide resolved
frontend/yarn.lock Outdated Show resolved Hide resolved
frontend/pages/user/profile/edit.vue Outdated Show resolved Hide resolved
@hay-kot hay-kot disabled auto-merge September 15, 2023 17:15
@p0lycarpio
Copy link
Contributor Author

Thank you for your feedback ! I made the modifications. For translations, I know that Mealie uses Crowdwin but the English-only strings are not present in the other languages interface. Is there a pipeline to launch?

@p0lycarpio p0lycarpio requested a review from hay-kot October 1, 2023 20:40
@hay-kot
Copy link
Collaborator

hay-kot commented Oct 7, 2023

Thank you for your feedback ! I made the modifications. For translations, I know that Mealie uses Crowdwin but the English-only strings are not present in the other languages interface. Is there a pipeline to launch?

Thanks! The other languages should fallback if there's no reference. But once this is merged Crowdin will automatically fill those with defaults and then people can start translating them. I realized that the Crowdin integration has been broken for some time, so I wanted to get that fixed before I merged this. Thanks for your patience!

Should be fixed today and then I'll merge this!

@hay-kot hay-kot merged commit 45022e1 into mealie-recipes:mealie-next Oct 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.0.0b] - "app" icon colors
2 participants