Fix ArrayInput makes the form dirty in strict mode #10421
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #9661
Solution
We had a workaround for adding validation on the ArrayInput itself (like min/max number of items) that triggered a register/unregister of the input in react-hook-form inside a
useEffect
. This effect is run twice in StrictMode.It appears the workaround isn't needed anymore to have validation on the ArrayInput.
How To Test
isDirty
. Run the story locally for React.StrictModeAdditional Checks
master
for a bugfix, ornext
for a featureAlso, please make sure to read the contributing guidelines.