Skip to content

Commit

Permalink
Bug 1574365 [wpt PR 18477] - [SyntheticModules] Allows for Fetching a…
Browse files Browse the repository at this point in the history
…nd Loading of JSON/Synthetic Modules, a=testonly

Automatic update from web-platform-tests
[SyntheticModules] Allows for Fetching and Loading of JSON/Synthetic Modules

This is the final change required for JSON Modules to be utilized by developers.
Following the acceptance of this change, if you run chromium with the JSONModules runtime flag, the following is now valid syntax:

<script type="module">
    import data from "./example.json";
</script>

This change introduces several things:

-It introduces the ability for ModuleScriptLoader to load JSON Modules
-It introduces the ability for ModuleScriptFetcher to retrieve JSON resources
-It introduces a new field to ModuleScriptCreationParams: response_mime_type_
-It introduces the JSONModules runtime flag to chromium

This change corresponds with the following V8 change:
https://chromium-review.googlesource.com/c/v8/v8/+/1761583

Bug: 967018
Change-Id: Ibcdb61659fb07047ffeead2ff4a55c450c183e43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731108
Reviewed-by: Hiroshige Hayashizaki <hiroshigechromium.org>
Reviewed-by: Hiroki Nakagawa <nhirokichromium.org>
Commit-Queue: Sam Sebree <sasebreemicrosoft.com>
Cr-Commit-Position: refs/heads/master{#688905}

--

wpt-commits: a8a1303f3dadc7392a426ca6525e23b6114bb066
wpt-pr: 18477

UltraBlame original commit: bff8292409ef3d02dff5515ced4ae1bb976fc58d
  • Loading branch information
marco-c committed Oct 4, 2019
1 parent a4556f1 commit 08c9af3
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
for (const value of [null, true, false, "string"]) {
promise_test(async t => {
const result = await import(`./${value}.json`);
assert_equals(result, value);
assert_equals(result.default, value);
}, `Non-object: ${value}`);
}

promise_test(async t => {
const result = await import("./array.json");
assert_array_equals(result, ["en", "try"]);
assert_array_equals(result.default, ["en", "try"]);
}, "Non-object: array");

0 comments on commit 08c9af3

Please sign in to comment.