Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rarian: use C++11 to unbreak the build #27071

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Conversation

barracuda156
Copy link
Contributor

Description

Fix the build

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@mohd-akram
Copy link
Member

What's the error?

@barracuda156
Copy link
Contributor Author

Fails to configure:

configure:17462: checking for tinyxml2
configure:17484: ccache /usr/bin/g++-4.2 -o conftest -pipe -Os -arch ppc -I/opt/local/include -L/opt/local/lib -Wl,-headerpad_max_install_names -arch ppc conftest.cpp  -ltinyxml2 >&5
In file included from conftest.cpp:28:
/opt/local/include/tinyxml2.h:365: error: expected ';' before 'override'
/opt/local/include/tinyxml2.h:368: error: expected `;' before 'int'
/opt/local/include/tinyxml2.h:372: error: expected ';' before 'override'
conftest.cpp:35: error: expected `;' at end of input
conftest.cpp:35: error: expected `}' at end of input
/opt/local/include/tinyxml2.h: In constructor 'tinyxml2::MemPoolT<ITEM_SIZE>::MemPoolT()':
/opt/local/include/tinyxml2.h:347: error: class 'tinyxml2::MemPoolT<ITEM_SIZE>' does not have any field named '_blockPtrs'
/opt/local/include/tinyxml2.h:347: error: class 'tinyxml2::MemPoolT<ITEM_SIZE>' does not have any field named '_root'
/opt/local/include/tinyxml2.h:347: error: class 'tinyxml2::MemPoolT<ITEM_SIZE>' does not have any field named '_currentAllocs'
/opt/local/include/tinyxml2.h:347: error: class 'tinyxml2::MemPoolT<ITEM_SIZE>' does not have any field named '_nAllocs'
/opt/local/include/tinyxml2.h:347: error: class 'tinyxml2::MemPoolT<ITEM_SIZE>' does not have any field named '_maxAllocs'
/opt/local/include/tinyxml2.h:347: error: class 'tinyxml2::MemPoolT<ITEM_SIZE>' does not have any field named '_nUntracked'
/opt/local/include/tinyxml2.h: In member function 'void tinyxml2::MemPoolT<ITEM_SIZE>::Clear()':
/opt/local/include/tinyxml2.h:354: error: '_blockPtrs' was not declared in this scope
/opt/local/include/tinyxml2.h:355: error: 'Block' was not declared in this scope
/opt/local/include/tinyxml2.h:355: error: 'lastBlock' was not declared in this scope
/opt/local/include/tinyxml2.h:358: error: '_root' was not declared in this scope
/opt/local/include/tinyxml2.h:359: error: '_currentAllocs' was not declared in this scope
/opt/local/include/tinyxml2.h:360: error: '_nAllocs' was not declared in this scope
/opt/local/include/tinyxml2.h:361: error: '_maxAllocs' was not declared in this scope
/opt/local/include/tinyxml2.h:362: error: '_nUntracked' was not declared in this scope
/opt/local/include/tinyxml2.h: In member function 'int tinyxml2::MemPoolT<ITEM_SIZE>::CurrentAllocs() const':
/opt/local/include/tinyxml2.h:369: error: '_currentAllocs' was not declared in this scope
/opt/local/include/tinyxml2.h: At global scope:
/opt/local/include/tinyxml2.h:370: error: expected unqualified-id at end of input
/opt/local/include/tinyxml2.h:370: error: expected `}' at end of input
configure:17484: $? = 1
configure: failed program was:
| /* confdefs.h */
| #define PACKAGE_NAME "rarian"
| #define PACKAGE_TARNAME "rarian"
| #define PACKAGE_VERSION "0.8.6"
| #define PACKAGE_STRING "rarian 0.8.6"
| #define PACKAGE_BUGREPORT ""
| #define PACKAGE_URL ""
| #define PACKAGE "rarian"
| #define VERSION "0.8.6"
| #define HAVE_STDIO_H 1
| #define HAVE_STDLIB_H 1
| #define HAVE_STRING_H 1
| #define HAVE_INTTYPES_H 1
| #define HAVE_STDINT_H 1
| #define HAVE_STRINGS_H 1
| #define HAVE_SYS_STAT_H 1
| #define HAVE_SYS_TYPES_H 1
| #define HAVE_UNISTD_H 1
| #define STDC_HEADERS 1
| #define HAVE_DLFCN_H 1
| #define LT_OBJDIR ".libs/"
| #define ENABLE_INSTALL 1
| #define ENABLE_SK_COMPAT 1
| #define ENABLE_OMF_READ 1
| #define ENABLE_SKDB_UPDATE 1
| #define HAVE_CHECK 0
| /* end confdefs.h.  */
| #include <tinyxml2.h>
| int
| main (void)
| {
| tinyxml2::XMLDocument doc
|   ;
|   return 0;
| }
| 
configure:17493: error: in `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_textproc_rarian/rarian/work/rarian-0.8.6':
configure:17495: error: no

@mohd-akram mohd-akram merged commit 64d03b1 into macports:master Dec 15, 2024
3 checks passed
@barracuda156 barracuda156 deleted the rarian branch December 15, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants