Draft: Dump with Type Check #360
Open
+70
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dn070017 Please check mypy failure. |
ujiuji1259
force-pushed
the
dump-type-check
branch
from
9149f85 to
9ee4466
Compare
Hi-king
reviewed
Jul 23, 2024
gokart/target.py
Outdated
| @@ -91,9 +93,14 @@ def _get_task_lock_params(self) -> TaskLockParams: | |||
|
|
|||
| def _load(self) -> Any: | |||
| with self._target.open('r') as f: | |||
| return self._processor.load(f) | |||
| obj = self._processor.load(f) | |||
| self._validator(obj) | |||
There was a problem hiding this comment.
@ujiuji1259 You can use retrun value of validator and let this process fail if return value is False
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new property
expected_output_dataframe_typeforgokart.TaskOnKartwhich allows the users to provide the Pandera schema. Ifexpected_output_dataframe_typeis provided, when loading (load) and storing (dump) the cached dataframe, it will automatically check if the dataframe meet the schema defined inexpected_output_dataframe_type. Seetest/test_task_on_kart.pyfor example usage.[must] fix error from mypy