-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extra gcs and s3 #339
Draft
yokomotod
wants to merge
13
commits into
m3dev:master
Choose a base branch
from
yokomotod:extra-gcs-and-s3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
extra gcs and s3 #339
+275
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yokomotod
force-pushed
the
extra-gcs-and-s3
branch
from
December 14, 2023 17:41
65c6c14
to
ea4bd03
Compare
yokomotod
force-pushed
the
extra-gcs-and-s3
branch
from
December 14, 2023 17:49
ea4bd03
to
7cedb1d
Compare
yokomotod
force-pushed
the
extra-gcs-and-s3
branch
from
December 14, 2023 18:43
a4dc79d
to
efef91a
Compare
yokomotod
force-pushed
the
extra-gcs-and-s3
branch
from
December 14, 2023 23:26
efef91a
to
6ef8a91
Compare
mski-iksm
reviewed
Dec 15, 2023
kitagry
reviewed
Dec 20, 2023
kitagry
reviewed
Dec 20, 2023
other option:
|
yokomotod
force-pushed
the
extra-gcs-and-s3
branch
from
January 19, 2024 07:34
228aafa
to
3e060ed
Compare
@hirosassa Hi! How do your team feel, as another well know users? 😃 especially |
How much does it actually affect disk size and install time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Goal
[s3]
and[gcs]
extras to reduce unnecessary dependenciespip install gokart
: not install gcs, s3 related depspip install gokart[s3]
: install with s3 related depspip install gokart[gcs]
: install with gcs related depspip install gokart[s3][gcs]
: install both (results same as with previous behavior)Sub Goal
usually, developers can run all unit tests without being conscious of extrasextras are installed by defaultpoetry install --extras=s3 --extras=gcs --with=dev-s3
explicitlyDiscussion
gokart[s3]
orgokart[gcs]
to worksToDO
test publishing on pypy dev