fix LoggerConfig inconsistency bug (#233)

* fix LoggerConfig * add comment
m3dev · Aug 10, 2021 · 1654f00 · 1654f00
1 parent 55bf7c4
commit 1654f00
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/gokart/build.py b/gokart/build.py
@@ -16,12 +16,12 @@ def __init__(self, level: int = logging.CRITICAL):
         self.level = level
 
     def __enter__(self):
-        logging.disable(self.level)
+        logging.disable(self.level - 10)  # subtract 10 to disable below self.level
         self.logger.setLevel(self.level)
         return self
 
     def __exit__(self, exception_type, exception_value, traceback):
-        logging.disable(self.default_level)
+        logging.disable(self.default_level - 10)  # subtract 10 to disable below self.level
         self.logger.setLevel(self.default_level)
 
 

diff --git a/test/test_build.py b/test/test_build.py
@@ -68,10 +68,15 @@ def test_build_dict_outputs(self):
 
 class LoggerConfigTest(unittest.TestCase):
     def test_logger_config(self):
-        for level, expected in ((logging.INFO, logging.INFO), (logging.DEBUG, logging.DEBUG), (logging.CRITICAL, logging.CRITICAL)):
-            with self.subTest(level=level, expected=expected):
+        for level, enable_expected, disable_expected in (
+            (logging.INFO, logging.INFO, logging.DEBUG),
+            (logging.DEBUG, logging.DEBUG, logging.NOTSET),
+            (logging.CRITICAL, logging.CRITICAL, logging.ERROR),
+        ):
+            with self.subTest(level=level, enable_expected=enable_expected, disable_expected=disable_expected):
                 with LoggerConfig(level) as lc:
-                    self.assertEqual(lc.logger.level, expected)
+                    self.assertTrue(lc.logger.isEnabledFor(enable_expected))
+                    self.assertTrue(not lc.logger.isEnabledFor(disable_expected))
 
 
 if __name__ == '__main__':