Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings
AbortController
support to cancel ongoing requests.Aside from that, if the same query/mutation triggered multiple requests, it will be canceled by default.
The only problem is to workout the interaction between cancellation and
dedup
andbatch
plugins.For
dedup
it is problematic to cancel a deduped request because that means it would cancel for other queries as well. There isn't a lot of options here other than "avoid" deduped requests abort signal to prevent mistakes.For
batch
, that would cancel the whole batched request. I don't think I have much choice here other than not supporting cancellation withbatch
.closes #90