Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fortran/gfortran] Enable tests that now pass #192

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tarunprabhu
Copy link
Contributor

Enable a number of tests that were disabled, but now pass.


Notes for reviewers

In the past, some tests pass for me, but fail on different configurations. I have included a larger number of reviewers this time to cover several targets and build/test configurations. If any tests fail on your setup, let me know and I will disable them again.

As a result of enabling these tests, some of the DisabledFiles.cmake files are empty. I have chosen to retain the files for now because there have been instances of regressions requiring tests to be temporarily disabled. Once flang becomes more stable, we can consider removing them.

Enable a number of tests that were disabled, but now pass.
Copy link
Contributor

@tblah tblah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes for me on aarch64 with optimization enabled. Thanks for keeping on top of this!

@@ -1010,16 +919,8 @@ file(GLOB FAILING_FILES CONFIGURE_DEPENDS
unformatted_subrecord_1.f90
widechar_IO_4.f90
zero_sized_1.f90
elemental_function_2.f90
do_check_1.f90
Copy link
Contributor

@kiranchandramohan kiranchandramohan Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (do_check_1.f90) failed for me.

@tarunprabhu
Copy link
Contributor Author

Thanks @tblah and @kiranchandramohan for taking a look. The tests that were incorrectly passing/failing have been disabled.

Copy link
Contributor

@tblah tblah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@jeanPerier jeanPerier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Tarun, this passes with my build and, for the few tests I checked, is in line with my expectations.

Copy link
Contributor

@kiranchandramohan kiranchandramohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. The latest set passes for me.

Copy link
Contributor

@ylzsx ylzsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Passes for me on LoongArch64 with optimization -O2 enabled.

Copy link
Member

@DavidTruby DavidTruby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

All the gfortran tests are disabled on Windows so I haven't checked any of this there; some day we should go through and enable any of the ones that should work on Windows but that's not really relevant to this PR.

@tarunprabhu
Copy link
Contributor Author

All the gfortran tests are disabled on Windows so I haven't checked any of this there; some day we should go through and enable any of the ones that should work on Windows but that's not really relevant to this PR.

Ah, right. I think the main reason I had them disabled was because some of the tests use the diff utility on *nix. I think I added some code to use cmp on Windows, but since I had no way to test it, I just disabled the entire thing on Windows.

Let me know when you have some time to look into this. It would be good to have this running on Windows, especially since it looks like these will be enabled on more architectures as well.

Copy link

@AlexisPerry AlexisPerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All passes for my configuration (x86, amd-rome node).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants