Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling default livebook theme #56

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

pnezis
Copy link
Contributor

@pnezis pnezis commented Jun 26, 2024

By default the look is the same as before:

image

With theme disabled:

image

With default theme and tucan dark theme (the axes labels are not visible since they are overridden by the default theme):

image

With theme disabled and tucan dark theme:

image

Closes #55

@pnezis
Copy link
Contributor Author

pnezis commented Jun 26, 2024

I have not pushed the bundle, let me know if you want me to do it. Also it is an opportunity to bump vega-lite versions 😄

Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few details and we can ship :)

lib/kino/vega_lite.ex Outdated Show resolved Hide resolved
lib/kino/vega_lite.ex Outdated Show resolved Hide resolved
lib/kino/vega_lite.ex Outdated Show resolved Hide resolved
test/kino/vega_lite_test.exs Outdated Show resolved Hide resolved
test/kino/vega_lite_test.exs Outdated Show resolved Hide resolved
test/kino/vega_lite_test.exs Show resolved Hide resolved
@pnezis pnezis force-pushed the configure-kino-vega-lite branch from 5d9f52f to fe997f9 Compare June 27, 2024 07:44
@pnezis
Copy link
Contributor Author

pnezis commented Jun 27, 2024

@jonatanklosko updated and force-pushed

@jonatanklosko jonatanklosko merged commit 68f8c6d into livebook-dev:main Jun 27, 2024
1 check passed
@jonatanklosko
Copy link
Member

🚀

@jonatanklosko
Copy link
Member

Released in v0.1.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optionally disable the livebook theme
2 participants