test(unit-tests): updating unit tests (#331) (#333)

Signed-off-by: shubhamchaudhary <[email protected]> Co-authored-by: Shubham Chaudhary <[email protected]>
litmuschaos · Feb 2, 2021 · 7d72b3e · 7d72b3e
1 parent 349a577
commit 7d72b3e
Show file tree

Hide file tree

Showing 2 changed files with 81 additions and 76 deletions.
diff --git a/pkg/controller/chaosengine/chaosengine_controller_test.go b/pkg/controller/chaosengine/chaosengine_controller_test.go
@@ -1764,6 +1764,11 @@ func TestReconcileForCreationAndRunning(t *testing.T) {
 								Image: "fake-runner-image",
 							},
 						},
+						Experiments: []litmuschaosv1alpha1.ExperimentList{
+							{
+								Name: "exp-1",
+							},
+						},
 					},
 				},
 

diff --git a/pkg/controller/resource/resource_test.go b/pkg/controller/resource/resource_test.go
@@ -992,43 +992,7 @@ func TestCheckChaosAnnotationDeploymentConfigs(t *testing.T) {
 			isErr: false,
 			check: true,
 		},
-		"Test Negative-1": {
-			engine: chaosTypes.EngineInfo{
-				Instance: &litmuschaosv1alpha1.ChaosEngine{
-					ObjectMeta: metav1.ObjectMeta{
-						Name:      "check-chaos-annotation-d3",
-						Namespace: "default",
-					},
-					Spec: litmuschaosv1alpha1.ChaosEngineSpec{
-						Appinfo: litmuschaosv1alpha1.ApplicationParams{
-							Applabel: "app=nginx3",
-							AppKind:  "deploymentconfig",
-						},
-						EngineState:     "active",
-						AnnotationCheck: "true",
-						Components: litmuschaosv1alpha1.ComponentParams{
-							Runner: litmuschaosv1alpha1.RunnerInfo{
-								Image: "fake-runner-image",
-							},
-						},
-						Experiments: []litmuschaosv1alpha1.ExperimentList{
-							{
-								Name: "exp-1",
-							},
-						},
-					},
-				},
-				AppInfo: &chaosTypes.ApplicationInfo{
-					Kind: "deploymentconfig",
-					Label: map[string]string{
-						"app": "nginx3",
-					},
-				},
-			},
-			isErr: true,
-			check: false,
-		},
-		"Test Negative-2": {
+		"Test Positive-3": {
 			engine: chaosTypes.EngineInfo{
 				Instance: &litmuschaosv1alpha1.ChaosEngine{
 					ObjectMeta: metav1.ObjectMeta{
@@ -1106,9 +1070,45 @@ func TestCheckChaosAnnotationDeploymentConfigs(t *testing.T) {
 				},
 			},
 
-			isErr: true,
+			isErr: false,
 			check: true,
 		},
+		"Test Negative-1": {
+			engine: chaosTypes.EngineInfo{
+				Instance: &litmuschaosv1alpha1.ChaosEngine{
+					ObjectMeta: metav1.ObjectMeta{
+						Name:      "check-chaos-annotation-d3",
+						Namespace: "default",
+					},
+					Spec: litmuschaosv1alpha1.ChaosEngineSpec{
+						Appinfo: litmuschaosv1alpha1.ApplicationParams{
+							Applabel: "app=nginx3",
+							AppKind:  "deploymentconfig",
+						},
+						EngineState:     "active",
+						AnnotationCheck: "true",
+						Components: litmuschaosv1alpha1.ComponentParams{
+							Runner: litmuschaosv1alpha1.RunnerInfo{
+								Image: "fake-runner-image",
+							},
+						},
+						Experiments: []litmuschaosv1alpha1.ExperimentList{
+							{
+								Name: "exp-1",
+							},
+						},
+					},
+				},
+				AppInfo: &chaosTypes.ApplicationInfo{
+					Kind: "deploymentconfig",
+					Label: map[string]string{
+						"app": "nginx3",
+					},
+				},
+			},
+			isErr: true,
+			check: false,
+		},
 	}
 	for name, mock := range tests {
 		t.Run(name, func(t *testing.T) {
@@ -1282,43 +1282,7 @@ func TestCheckChaosAnnotationRollouts(t *testing.T) {
 			isErr: false,
 			check: true,
 		},
-		"Test Negative-1": {
-			engine: chaosTypes.EngineInfo{
-				Instance: &litmuschaosv1alpha1.ChaosEngine{
-					ObjectMeta: metav1.ObjectMeta{
-						Name:      "check-chaos-annotation-d3",
-						Namespace: "default",
-					},
-					Spec: litmuschaosv1alpha1.ChaosEngineSpec{
-						Appinfo: litmuschaosv1alpha1.ApplicationParams{
-							Applabel: "app=nginx3",
-							AppKind:  "rollout",
-						},
-						EngineState:     "active",
-						AnnotationCheck: "true",
-						Components: litmuschaosv1alpha1.ComponentParams{
-							Runner: litmuschaosv1alpha1.RunnerInfo{
-								Image: "fake-runner-image",
-							},
-						},
-						Experiments: []litmuschaosv1alpha1.ExperimentList{
-							{
-								Name: "exp-1",
-							},
-						},
-					},
-				},
-				AppInfo: &chaosTypes.ApplicationInfo{
-					Kind: "rollout",
-					Label: map[string]string{
-						"app": "nginx3",
-					},
-				},
-			},
-			isErr: true,
-			check: false,
-		},
-		"Test Negative-2": {
+		"Test Positive-3": {
 			engine: chaosTypes.EngineInfo{
 				Instance: &litmuschaosv1alpha1.ChaosEngine{
 					ObjectMeta: metav1.ObjectMeta{
@@ -1400,9 +1364,45 @@ func TestCheckChaosAnnotationRollouts(t *testing.T) {
 				},
 			},
 
-			isErr: true,
+			isErr: false,
 			check: true,
 		},
+		"Test Negative-1": {
+			engine: chaosTypes.EngineInfo{
+				Instance: &litmuschaosv1alpha1.ChaosEngine{
+					ObjectMeta: metav1.ObjectMeta{
+						Name:      "check-chaos-annotation-d3",
+						Namespace: "default",
+					},
+					Spec: litmuschaosv1alpha1.ChaosEngineSpec{
+						Appinfo: litmuschaosv1alpha1.ApplicationParams{
+							Applabel: "app=nginx3",
+							AppKind:  "rollout",
+						},
+						EngineState:     "active",
+						AnnotationCheck: "true",
+						Components: litmuschaosv1alpha1.ComponentParams{
+							Runner: litmuschaosv1alpha1.RunnerInfo{
+								Image: "fake-runner-image",
+							},
+						},
+						Experiments: []litmuschaosv1alpha1.ExperimentList{
+							{
+								Name: "exp-1",
+							},
+						},
+					},
+				},
+				AppInfo: &chaosTypes.ApplicationInfo{
+					Kind: "rollout",
+					Label: map[string]string{
+						"app": "nginx3",
+					},
+				},
+			},
+			isErr: true,
+			check: false,
+		},
 	}
 
 	for name, mock := range tests {
-Original file line number
+Diff line change
@@ Expand Up / @@ -1764,6 +1764,11 @@ func TestReconcileForCreationAndRunning(t *testing.T) { @@
     								Image: "fake-runner-image",
     							},
     						},
+    						Experiments: []litmuschaosv1alpha1.ExperimentList{
+    							{
+    								Name: "exp-1",
+    							},
+    						},
     					},
     				},
@@ Expand Down @@