Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle mixed values and expressions in parameters #806

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

shouwn
Copy link
Member

@shouwn shouwn commented Dec 17, 2024

Motivation

  • The vararg args: Any type parameter was designed expecting only values, but the user expects a mix of values and expressions.
  • So the user uses a mix of values and expressions, which results in an error that is difficult for the user to understand.

Modifications

  • For functions that can mix values and expressions, add logic to prevent expressions from being treated as values.

Result

  • The function can perform as the user expects it to.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.70%. Comparing base (3a58ff8) to head (5560ab4).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #806   +/-   ##
=======================================
  Coverage   90.69%   90.70%           
=======================================
  Files         337      337           
  Lines        3536     3539    +3     
  Branches      221      222    +1     
=======================================
+ Hits         3207     3210    +3     
  Misses        261      261           
  Partials       68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cj848 cj848 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a situation that requires a quick patch? It seems like it should be released.

@cj848 cj848 merged commit 5974ea7 into main Dec 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants