Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support module for eclipselink (jakarta, javax) #451

Merged
merged 31 commits into from
Sep 8, 2023

Conversation

SeongYunKim
Copy link
Contributor

Motivation:

  • eclipselink-support module to help execute the JPQL query using only Eclipselink without any spring dependency (jakarta, javax)

Modifications:

  • eclipselink-support module
  • eclipselink-support-javax module
  • example and integration test for eclipselink-support module

Commit Convention Rule

Commit type Description
feat New Feature
fix Fix bug
docs Documentation only changed
ci Change CI configuration
refactor Not a bug fix or add feature, just refactoring code
test Add Test case or fix wrong test case
style Only change the code style(ex. white-space, formatting)
chore It refers to minor tasks such as library version upgrade, typo correction, etc.
  • If you want to add some more commit type please describe it on the Pull Request

Result:

Part of the work to resolve #412 (Support eclipselink) issue
(I'll implement example for eclipselink-support-javax module through next pull request)

@SeongYunKim SeongYunKim changed the title Feature/eclipselink support support module for eclipselink (jakarta, javax) Sep 8, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 95.00% and project coverage change: +1.22% 🎉

Comparison is base (769f5d3) 90.98% compared to head (feadc78) 92.20%.
Report is 3 commits behind head on develop/3.0.0.

Additional details and impacted files
@@                Coverage Diff                @@
##           develop/3.0.0     #451      +/-   ##
=================================================
+ Coverage          90.98%   92.20%   +1.22%     
=================================================
  Files                251      257       +6     
  Lines               2783     2797      +14     
  Branches             169      163       -6     
=================================================
+ Hits                2532     2579      +47     
+ Misses               203      172      -31     
+ Partials              48       46       -2     
Files Changed Coverage Δ
...sl/support/eclipselink/javax/JpqlRendererHolder.kt 33.33% <33.33%> (ø)
...tlinjdsl/support/eclipselink/JpqlRendererHolder.kt 66.66% <66.66%> (ø)
...ort/eclipselink/javax/JpqlJpaEntityManagerUtils.kt 100.00% <100.00%> (ø)
...link/javax/extension/JpaEntityManagerExtensions.kt 100.00% <100.00%> (ø)
...l/support/eclipselink/JpqlJpaEntityManagerUtils.kt 100.00% <100.00%> (ø)
...clipselink/extension/JpaEntityManagerExtensions.kt 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@shouwn shouwn merged commit b540742 into line:develop/3.0.0 Sep 8, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants