-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support module for eclipselink (jakarta, javax) #451
Merged
shouwn
merged 31 commits into
line:develop/3.0.0
from
SeongYunKim:feature/eclipselink-support
Sep 8, 2023
Merged
support module for eclipselink (jakarta, javax) #451
shouwn
merged 31 commits into
line:develop/3.0.0
from
SeongYunKim:feature/eclipselink-support
Sep 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # libs.versions.toml
SeongYunKim
requested review from
pickmoment,
huisam,
cj848 and
shouwn
as code owners
September 8, 2023 01:36
SeongYunKim
changed the title
Feature/eclipselink support
support module for eclipselink (jakarta, javax)
Sep 8, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop/3.0.0 #451 +/- ##
=================================================
+ Coverage 90.98% 92.20% +1.22%
=================================================
Files 251 257 +6
Lines 2783 2797 +14
Branches 169 163 -6
=================================================
+ Hits 2532 2579 +47
+ Misses 203 172 -31
+ Partials 48 46 -2
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
shouwn
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Modifications:
Commit Convention Rule
commit type
please describe it on the Pull RequestResult:
Part of the work to resolve #412 (Support eclipselink) issue
(I'll implement example for eclipselink-support-javax module through next pull request)