Use vmtest-action version 0.8 in CI #795
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not at all clear why, but various tests fail when run in a vmtest VM that has the hosts /tmp/ mounted inside. The issue seems fixed once we switch to using named temporary files ¯\_(°ペ)_/¯ Switch over to using them, which makes a lot more sense in many cases anyway, because some tests are currently making up a path that does not represent reality. Signed-off-by: Daniel Müller <[email protected]>
danielocfb
force-pushed
the
topic/vmtest-action-0.8
branch
from
c33d706 to
a8e0302
Compare
With vmtest-action version 0.8 released, it makes the most sense for us to consume this version as opposed to the current snapshot from the master branch. This way, we anticipate to consume stable releases and have Dependabot manage version bumps for us. Signed-off-by: Daniel Müller <[email protected]>
danielocfb
force-pushed
the
topic/vmtest-action-0.8
branch
from
a8e0302 to
4d2fa41
Compare
d-e-s-o
force-pushed
the
topic/vmtest-action-0.8
branch
from
91a0c35 to
4d2fa41
Compare
|
So the issue here is with 9P. See discussion here: danobi/vmtest#83 Hence, this PR is blocked until this issue is resolved, I suppose. |
|
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label or comment or it will be closed in 5 days. |
|
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label or comment or it will be closed in 5 days. |
|
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label or comment or it will be closed in 5 days. |
|
Closing pull request as it is stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With vmtest-action version 0.8 released, it makes the most sense for us to consume this version as opposed to the current snapshot from the master branch. This way, we anticipate to consume stable releases and have Dependabot manage version bumps for us.