Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small updates/corrections #78

Closed
wants to merge 0 commits into from
Closed

small updates/corrections #78

wants to merge 0 commits into from

Conversation

goi42
Copy link
Contributor

@goi42 goi42 commented Feb 7, 2018

No description provided.

@alexpearce
Copy link
Member

I guess your editor is configured specifically, but it's a little annoying having changes just for the line width. This is partly our fault, we should provide an edtior config file or something, but while we don't have that I think these sorts of changes just muddy the git blame history.

For the formatting issue: is it possible to use LaTeX markup here instead? e.g. $$D^{*+}$$

@apuignav
Copy link
Contributor

apuignav commented Feb 8, 2018

@alexpearce We should provide a style guide? I would say one sentence one line...

@alexpearce
Copy link
Member

Opened #79 for discussion on style guides/editor configs.

@goi42
Copy link
Contributor Author

goi42 commented Feb 8, 2018

@alexpearce Apologies for the small change--I opened it up just to fix the the D* problem.

I corrected the line lengths to be more in-line with the rest of the repository--I was under the impression that shorter line lengths made for easier reading of the changes as there will not be such long lines of text marked as different. I can roll back the line-length changes if you'd like.

@apuignav
Copy link
Contributor

apuignav commented Feb 8, 2018

Please do, I think we need to fix all at once depending on what we decide in #79.

However, thanks a lot for the effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants