Symfony 5 #324
Symfony 5 #324
Conversation
composer.json
Outdated
| }, | ||
| "require-dev": { | ||
| "doctrine/mongodb-odm": "^1.1|^2.0", | ||
| "doctrine/mongodb-odm-bundle": "^3.0", |
There was a problem hiding this comment.
Try to allow mongodb-odm-bundle 4 too
There was a problem hiding this comment.
I tried, but mongo-odm-bundle 4 removed https://github.com/doctrine/DoctrineMongoDBBundle/blob/3.5/DataCollector/PrettyDataCollector.php in 4.*
And brokes our tests, maybe I could change the tests 🙄
There was a problem hiding this comment.
But in 3.* we have PrettyDataCollector.php and StandardDataCollector.php
In 4.* we have only CommandDataCollector.php
There was a problem hiding this comment.
Well, I can't find anything in mongo-odm-bundle mentioting the removal of PrettyDataCollector. Anyway, can't you just use CommandDataCollector instead?
There was a problem hiding this comment.
I opened an issue to see if we can get some feedback from bundle maintainers: doctrine/DoctrineMongoDBBundle#606
There was a problem hiding this comment.
I tried to use CommandDataCollector, but ODM bundle brokes a lot of codes :/
There was a problem hiding this comment.
There's a hard BC break regarding data collectors from 3.x to 4.x. Unfortunately, we can't really fix that as 3.x does not know about the commands. This is a side effect of the driver change underneath the hood.
As for the original issue, there's no point adding ^2.0 for ODM if you don't allow 4.0 for the bundle: 3.x is not compatible with ODM 2.0 and will prevent installing it anyways.
Last but not least, you should also change the constraint for ODM to ^1.3|^2.0, as 1.1 has been EOL'd a while ago and doesn't contain the forward compatibility and deprecation layer for 2.0.
|
@garak
🤔 Well maybe we need to take the decision to create a branch support for SF 3.4 and an other one for SF 4/5.. @alcaeus Did you think is the right thing to do? |
|
I absolutely agree on that. |
|
Yes, it's not possible to support Symfony 3.4 and 5.0 if you have a data collector. I haven't gotten around to finishing this in the ODM bundle, but will try to do so early next week. |
|
One more word: I would highly suggest splitting off the ODM 2.0 change from this PR: 1.3 and the corresponding 3.6 version of the bundle support Symfony 5; there's no need to worry about ODM 2.0 right now. You should use a separate PR for that as it may entail significantly more changes. |
|
Ok thanks for your answer! 👍 @garak If you have an advice for branch.. Could we have futur tags v5.* on a new branch named 3.4? And the a futur tags v6.* on master? Or a branch 4.4 is needed? |
|
@Spike31 tag names don't depend on branch names, but I'd keep consistency just for a matter of human readability |
|
Yes it's just for context: SF 2.8/3.4 => branch 3.4 => tags until v5.* |
|
@garak I have to remove DataCollector because in the new ODM bundle there no more Logger to get Collector...Methods was deprecated and deleted! Anymay, I think we could merge into master and create a new major version |
|
LGTM 👍 |
|
Congratulations on your arrival in the Symfony organization! |
|
close #322 |
@garak
I created a new PR and made some little changes in travis.yml and TestCase.
I remove tests for SF 2.8 because we need to require doctrine/doctrine-bundle but this bundle required SF 3.4...
And I looked at the other bundles a bit, and kept the master branch compatible with 2.8 is no longer really a relevant thing.
But composer failed with SF 5.0 and
doctrine/mongodb-odm-bundleif you have an idea?