Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elevationBrushes to match WinUI #1234

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Difegue
Copy link
Contributor

@Difegue Difegue commented Sep 24, 2024

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

Card controls that use ControlElevationBrush show broken borders, as the gradient remains at the height of regular button/combobox controls.
Conversely, if Card controls are what are shown first, the ElevationBrush will not function properly for ComboBoxes and Buttons.

This also affects textboxes that are larger in height than the normal one. The replacement was to use a different ElevationBrush that does a full gradient, but this is non-canonical relative to WinUI.

I've also noticed that NumberBoxes/PasswordBoxes don't have a correct bottom border - The idea was probably to rely on the additional accent border instead, but that doesn't work as intended.

image

Issue Number: N/A

What is the new behavior?

  • ControlElevationBrush works properly.
  • TextElevationBrush has been fixed to match WinUI.
  • NumberBox/PasswordBox has been fixed to use the ElevationBrush properly alongside the additional accent border

Other information

Making the brush not-shared is necessary for it to work properly with content of any height
@github-actions github-actions bot added controls Changes to the appearance or logic of custom controls. styles Topic is related to styles PR Pull request release labels Sep 24, 2024
@github-actions github-actions bot added the ⭐ top pull request Top pull request. label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controls Changes to the appearance or logic of custom controls. PR Pull request release ⭐ top pull request Top pull request. styles Topic is related to styles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant