-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft: Implemented some wrapping examples using shape the term package #53
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR @jmcavanillas! Re: the CPU usage, are you testing this on the latest Minttea with Riot 0.0.9? |
I am testing with minttea main branch and riot 0.0.8, I tried to update to riot 0.0.9 but dune did not want to build due to a warning with |
Yeah I think minttea need an update to work with riot 0.0.9, I see you have a branch with some updates about it
|
I have merged your updates to minttea and now they usually work better at 60 fps and the CPU fans behave better but sometimes they do not. Now there is a new issue, when I enter some text in the input and then press intro to finish the program, sometimes it finishes as expected, but other times it just print final output but does not finish, it gets stuck, and the fans go BRRR! 🔥 again. A) Steps to reproduce
B) I run the example multiple times at 60 fps without rebuilding and some runs present heavy input lag. Setting fps to a lower value seems to reduce the lag cases but I still experience issue A at 2 fps
|
Hang Video: (The program exits because I press Ctrl +C) Grabacion.de.pantalla.desde.2024-04-17.20-35-30.webmI have another larger video showing lag and much higher CPU usage but I cannot upload it here |
Opening this PR to include wrap and wrap by word showcases using https://github.com/jmcavanillas/shape-the-term
The examples are functional and ready for review but there are a couple of issues to address,
To be completed / addressed before merging: