Api mode cffi compile #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cffi code is much faster when compiled with a c compiler (API mode) rather than using libfffi (ABI mode) - however this requires a compiler to be installed .
This change allows an install to be made using
PANGOCAIROCFFI_API_MODE=1 PANGOCFFI_API_MODE=1 CAIROCFFI_API_MODE=1 XCFFIB_API_MODE=1 pip3 install cairocffiVarious other projects (pangocffi and pangocairocffi) can then benefit from similar changes.
This change requires xcffib and cairocffi and pangcffi changes to be accepted - see here and here and here
During installation
PANGOCAIROCFFI_API_MODE=0orPANGOCAIROCFFI_API_MODEnot set defaults to the previous ABI mode install which incurs lever overhead on load, runs the ffi_build as before and will dynamically translate arguments to C using the general libffi.During installation
PANGOCAIROCFFI_API_MODE=1compiles a shared library / C extension which dynamically depends on xcd.At runtime if the shared library / C extension is present it will be used (unless
PANGOCAIROCFFI_API_MODE =0). The user does not have to arrange forPANGOCAIROCFFI_API_MODE =1to be set. If the extension is not present, the old behavior is used.To make this work I added the relevant FFI calls / setup.py calls to have the C extension be built.
I don't suggest this be default, but API mode is a potential substantial performance improvement. It also allows full speed threading as the C side unlocks the GIL.