feat: skip infoview breaking test on major version bump #459
Conversation
joneugster
commented
Jun 3, 2024
•
joneugster
commented
- depends on: feat: auto-publish infoview #458
It looks like the Windows CI is indeed able to execute the test as is. But maybe it uses WSL and the general user doesn't? |
| @@ -0,0 +1,18 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| PUBLISHED_VERSION="$(npm view @leanprover/infoview-api version --no-workspaces)" | |||
There was a problem hiding this comment.
Is this supposed to be the infoview-api version?
There was a problem hiding this comment.
no it's supposed to be @leanprover/infoview, my bad!
|
|
||
| PUBLISHED_VERSION="$(npm view @leanprover/infoview-api version --no-workspaces)" | ||
| NEW_VERSION="$(sed -n 's/^\s*"version":\s*"\(.*\)",\s*/\1/p' ./package.json)" | ||
| PUBLISHED_MAJOR="$(cut -d '.' -f 1 <<< $PUBLISHED_VERSION)" |
There was a problem hiding this comment.
If the first component of the semantic version is 0, then the major version is the second component of the semantic version. This will yield a major version of 0 for 0.7.0, but it should be 7.
There was a problem hiding this comment.
I thouht semantic versioning is usually Major-Minor-Patch. is your scheme ...-Major-Minor, i.e would it be fine to always check the first two terms?
Can fix that tomorrow
