Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tweak delta expansion heuristics #6335

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Command-Master
Copy link
Contributor

@Command-Master Command-Master commented Dec 8, 2024

This PR attempts to make defeq not compare the arguments before unfolding when there is an application of a projection function.

Related Zulip

@Command-Master Command-Master changed the title Experiment tweaking defeq heuristic feat: tweak delta expansion heuristics Dec 8, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 8, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 8, 2024

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 762c5758f51cb7d646dc1c4668a38a7e6d7704c5 --onto 6e60d130845855a9c3263c235bcbcc543b9b5c32. (2024-12-08 05:36:51)
  • 💥 Mathlib branch lean-pr-testing-6335 build failed against this PR. (2024-12-08 06:17:24) View Log
  • 💥 Mathlib branch lean-pr-testing-6335 build failed against this PR. (2024-12-08 12:15:10) View Log

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 8, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 8, 2024
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Dec 8, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 8, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants