Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add
BitVec.(getMSbD, msb)_replicate
,replicate_append_replicate_eq
and support theorems #6326base: master
Are you sure you want to change the base?
feat: add
BitVec.(getMSbD, msb)_replicate
,replicate_append_replicate_eq
and support theorems #6326Changes from 17 commits
881e80c
63a6bb5
44eb8dc
5518a6e
edc4ac6
e78f4ac
41046c6
ae5ed7a
4b9e02a
599c5b7
f4f2721
d1b8e3c
d22d1eb
1318d91
da439d6
a8c65d6
523af29
d704a52
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This proof can probably be shortened! But let's see if we can avoid it entirely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be much simpler if you introduced
BitVec.reverse
first, and prove this viarw [← getLsbD_reverse, reverse_replicate, getLsbD_replicate, getLsbD_reverse]
Could you have a go at that? It should avoid all the index munging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @kim-em! Am currently working on the
reverse
on a different branch to avoiding adding too much stuff here (I am trying to follow the same design strategies asList
, treating the bitvec as a list of bools).