[in_app_purchase] Update Play Billing library to 7.1.1 #4
+1,460
−670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcin Chudy <[email protected]>
Signed-off-by: Marcin Chudy <[email protected]>
Signed-off-by: Marcin Chudy <[email protected]>
Signed-off-by: Marcin Chudy <[email protected]>
Signed-off-by: Marcin Chudy <[email protected]>
Signed-off-by: Marcin Chudy <[email protected]>
Signed-off-by: Marcin Chudy <[email protected]>
Signed-off-by: Marcin Chudy <[email protected]>
Signed-off-by: Marcin Chudy <[email protected]>
Signed-off-by: Marcin Chudy <[email protected]>
Signed-off-by: Marcin Chudy <[email protected]>
Signed-off-by: Marcin Chudy <[email protected]>
Signed-off-by: Marcin Chudy <[email protected]>
mchudy
force-pushed
the
feature/in-app-purchase-play-billing-upgrade
branch
from
3dc6578 to
1ecb837
Compare
RobertOdrowaz
approved these changes
Dec 3, 2024
...purchase/in_app_purchase_android/lib/src/billing_client_wrappers/billing_client_wrapper.dart
Outdated
Show resolved
Hide resolved
|
|
||
| @override | ||
| bool operator ==(Object other) { | ||
| if (identical(other, this)) { |
There was a problem hiding this comment.
PendingPurchasesParamsWrapper doesn't have identical but it doesn't seem to be consistent in the existing code either
There was a problem hiding this comment.
Yeah I tried to follow pattern from other files
| @@ -26,6 +26,7 @@ class SubscriptionOfferDetailsWrapper { | |||
| required this.offerTags, | |||
| required this.offerIdToken, | |||
| required this.pricingPhases, | |||
| this.installmentPlanDetails, | |||
There was a problem hiding this comment.
IMO this should be required if it's always provided even if it can be null to avoid someone forgetting to pass the value. On the other hand offerId is not required so someone has a different option
There was a problem hiding this comment.
I agree, but that's the way it's done in all wrappers. Using multiple standards is probably not the best idea, but I'll also leave it to the further review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Play Billing Library to the latest version 7.1.1. Exposes new APIs as per release notes:
ProductDetails.InstallmentPlanDetailsPendingPurchasesParamsand removes the deprecatedenablePendingPurchasesmethod onBillingClientWrapper(breaking change)Purchase.PendingPurchaseUpdateProrationModeas it has been removed from the native library (breaking change)This PR introduces breaking changes in
in_app_purchase_android, but does not introduce any breaking changes on the platform interface level.Fixes flutter/flutter#147394
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.