From triage: @zoeyfan Is the request only to update the version, or to also add the new APIs?

@yaakovschectman both, add new APIs available in the new version of the Play Billing library.

@stuartmorgan I’m working on this migration along with providing new features from the Play Billing 7 library and I have a question on the best API design for exposing https://developer.android.com/reference/com/android/billingclient/api/PendingPurchasesParams.Builder#enablePrepaidPlans() to the Dart client.

We have a depracated enablePendingPurchases method on the BillingClient which was made no-op in this commit flutter/packages@bf92be8 as enabling pending purchases for one time products in mandatory https://developer.android.com/reference/com/android/billingclient/api/PendingPurchasesParams.Builder#enableOneTimeProducts().


Should we:

• Add a new paremeter to BillingClient.startConnection? Should it be a simple boolean enablePrepaidPlans or better create a class wrapper PendingPurchaseParams (more futureproof?)
• Revert the deprecation on this method and make it take some parameter for this option. Sounds like a weird change though and providing this param has to be done while constructing the client.
• Create a new method likeenablePendingPurchasesForPrepaidPlans?
• Maybe it’s also time to remove the deprecated method from the package to save confusion? This migration will cause a breaking change in the Android interface anyway with the removal of the ProrationMode enum on the native side. As enablePendingPurchases has been a no-op for a long time already, it would also be a trivial migration for the package users.

@gmackall for input on the above.

I think adding a new class wrapper PendingPurchaseParams and using that as a new parameter to BillingClient.startConnection sounds like a good solution. Its a bit more clunky than just using a simple bool, but if the Android folks end up adding more elements to PendingPurchasesParams we could end up in an awkward spot and require another breaking change to remove the bool and replace with a wrapper for the class.

Maybe it’s also time to remove the deprecated method from the package to save confusion? This migration will cause a breaking change in the Android interface anyway with the removal of the ProrationMode enum on the native side. As enablePendingPurchases has been a no-op for a long time already, it would also be a trivial migration for the package users.

This sounds good to me if we are going to be forced to make a breaking change regardless