Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add position and top property in stylePrpos for custom styling #832

Closed
wants to merge 3 commits into from
Closed

feat: add position and top property in stylePrpos for custom styling #832

wants to merge 3 commits into from

Conversation

mdkaifansari04
Copy link
Contributor

@mdkaifansari04 mdkaifansari04 commented Nov 30, 2024 •
edited
Loading

Notes for Reviewers
Add conditional top styling for sticky position

  • Introduced logic to apply top: 5rem only when the position is set to 'sticky'.
  • Default behavior remains unaffected for other position values (e.g., 'relative').
  • Ensured smooth handling of dynamic styling via props.

Screenshot:
image

Applied the styleProps from the CategoryFilterSidebar at /catalog page in Layer5 Cloud

Signed commits

  • Yes, I signed my commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitamrutiya amitamrutiya Awaiting requested review from amitamrutiya

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdkaifansari04 @amitamrutiya