test(playwright): adding data-testid to support e2e tests #744
Conversation
Signed-off-by: yash37158 <[email protected]>
| @@ -215,7 +215,7 @@ function TransferList({ | |||
| listId?: string | |||
| ) => ( | |||
| <StyledPaper> | |||
| <List dense component="div" role="list"> | |||
There was a problem hiding this comment.
I think it's better to use test id in meshery/meshery as the parent of this sistent element, and find them by role or aria-label. It's enough to distinguish the element i think. Wdyt?
https://playwright.dev/docs/api/class-framelocator#frame-locator-get-by-label
|
@yash37158 Are you suggesting to add If it is meant for Meshery UI, I would suggest against this, as it can confuse future |
I agree with this especially MUI styled do not accept non standard attributes like data-testid if im not mistaken |
|
@jerensl I understand that the Meshery UI has some reliability issues when it comes to consistently loading components. Additionally, dependency injection isn't feasible within the Playwright tests. What other options are available? |
Notes for Reviewers
Added data-testid for supporting playwright e2e test for UI/Environments
This PR fixes UI/environment Playwright test
Signed commits