generated from layer5io/layer5-repo-template
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[components]: Toolbar custom components #122
Merged
leecalcote
merged 6 commits into
layer5io:master
from
sudhanshutech:toolbar-customSearch
Oct 29, 2023
Merged
[components]: Toolbar custom components #122
leecalcote
merged 6 commits into
layer5io:master
from
sudhanshutech:toolbar-customSearch
Oct 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
sudhanshutech
commented
Oct 5, 2023
nebula-aac
reviewed
Oct 6, 2023
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
sudhanshutech
changed the title
feat(search-bar): add custom search bar component for Toolbar
feat(search & column): add custom search-bar and view-column component for Toolbar
Oct 6, 2023
…o toolbar-customSearch
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
sudhanshutech
changed the title
feat(search & column): add custom search-bar and view-column component for Toolbar
[components]: Toolbar custom components
Oct 11, 2023
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
Can we merge this @nebula-aac // @leecalcote |
You got it, @sudhanshutech |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR adds:
Custom components for toolbar
Related Issue: #118 #86 #125
I will be adding column component for tables
Signed commits