Updated Twitter logo to X #336
Conversation
In response to user feedback, this commit addresses the spacing concerns within the GetNighthawk website's UI. The existing design was visually appealing but lacked sufficient spacing between certain components. Changes Made: - Added margin-bottom to the analysis, distribution, and standards-based cards to create a clear distinction between them and improve readability. - Introduced appropriate spacing between the 'Nighthawk & Meshery' section and the 'Layer 7 Performance Analysis' division to enhance the overall visual balance. These adjustments have been carefully implemented to maintain the smooth and polished UI while ensuring a more comfortable viewing experience for users. The improved spacing creates a harmonious layout, allowing each component to breathe and stand out effectively. Resolves Issue: layer5io#290 Signed-off-by: Akhilender [email protected] Signed-off-by: Akhilender <[email protected]>
Refactored the CSS code to introduce a custom scrollbar consistent with modern design trends. The new scrollbar design aligns with the desired appearance, replacing the default one. Changes Made: - Added custom scrollbar CSS rules. - Removed the default scrollbar appearance. These adjustments have been carefully implemented to maintain the smooth and polished UI. Resolves Issue: layer5io#327 Signed-off-by: Akhilender <[email protected]>
- Updated the Twitter logo on the GetNighthawk.dev website from the old logo to the new X logo. - This change aligns with the desired state of the website and ensures consistency with branding. Fixes layer5io#325 Signed-off-by: Akhilender <[email protected]>
✅ Website preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- Removed the redundant css code for custom scrollbar Signed-off-by: Akhilender Bongirwar <[email protected]>
- Changed back the css of index.scss to its original state. - Removed the changes related to the other issue Signed-off-by: Akhilender Bongirwar <[email protected]>
There was a problem hiding this comment.
hey @akhilender-bongirwar your branch having other commits also beside the required changes needed for the issue. U should create separate branches for resolving different issues!
|
Hey @abhijeetgauravm , actually I have created separate branches as you can see
But yeah the changes from the other branch also came. |
|
Let's discuss it on the websites call. |
|
Hey @abhijeetgauravm , could you please review this PR : ) |
|
@akhilender-bongirwar Can you revert the index.scss changes ? Everything else looks fine. |
Signed-off-by: Akhilender Bongirwar <[email protected]>
|
the current on-hover effect (color) on X logo isn't ideal. |
- Implemented a white color fill on hover. - Aligns with design standards of hover effect of meshery.io Signed-off-by: Akhilender Bongirwar <[email protected]>
|
@vishalvivekm , could you please review this ? |
|
@akhilender-bongirwar hover effect doesn't work and and no twitter handle is linked |
Description
This PR fixes #325
Notes for Reviewers
Signed commits