Enhanced Spacing for Improved Component Layout #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In response to user feedback, this commit addresses the spacing concerns within the GetNighthawk website's UI. The existing design was visually appealing but lacked sufficient spacing between certain components. Changes Made: - Added margin-bottom to the analysis, distribution, and standards-based cards to create a clear distinction between them and improve readability. - Introduced appropriate spacing between the 'Nighthawk & Meshery' section and the 'Layer 7 Performance Analysis' division to enhance the overall visual balance. These adjustments have been carefully implemented to maintain the smooth and polished UI while ensuring a more comfortable viewing experience for users. The improved spacing creates a harmonious layout, allowing each component to breathe and stand out effectively. Resolves Issue: layer5io#290 Signed-off-by: Akhilender [email protected] Signed-off-by: Akhilender <[email protected]>
Refactored the CSS code to introduce a custom scrollbar consistent with modern design trends. The new scrollbar design aligns with the desired appearance, replacing the default one. Changes Made: - Added custom scrollbar CSS rules. - Removed the default scrollbar appearance. These adjustments have been carefully implemented to maintain the smooth and polished UI. Resolves Issue: layer5io#327 Signed-off-by: Akhilender <[email protected]>
In response to user feedback, this commit addresses the spacing concerns within the GetNighthawk website's UI. The existing design was visually appealing but lacked sufficient spacing between certain components. Changes Made: - Added margin-bottom to the analysis, distribution, and standards-based cards to create a clear distinction between them and improve readability. - Introduced appropriate spacing between the 'Nighthawk & Meshery' section and the 'Layer 7 Performance Analysis' division to enhance the overall visual balance. These adjustments have been carefully implemented to maintain the smooth and polished UI while ensuring a more comfortable viewing experience for users. The improved spacing creates a harmonious layout, allowing each component to breathe and stand out effectively. Resolves Issue: layer5io#290 Signed-off-by: Akhilender <[email protected]>
✅ Website preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Could anyone please review this PR ? |
vishalvivekm
reviewed
Oct 2, 2023
There was a problem hiding this comment.
LGTM. isn't 12 rem bottom-margin too much here?
I'll also request @ritiksaxena124 to take a look
Current bottom-margin:
After these changes:
- Changed from 12rem to 6rem for proper visibility of the website. - The website looks consistent now. Signed-off-by: Akhilender <[email protected]>
|
@vishalvivekm, could you please review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In response to user feedback, this commit addresses the spacing concerns within the GetNighthawk website's UI. The existing design was visually appealing but lacked sufficient spacing between certain components.
Changes Made:
These adjustments have been carefully implemented to maintain the smooth and polished UI while ensuring a more comfortable viewing experience for users. The improved spacing creates a harmonious layout, allowing each component to breathe and stand out effectively.
This PR fixes #290
Notes for Reviewers
Signed commits