Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 #75

Merged
merged 8 commits into from
Nov 15, 2024

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 7, 2024

Tests use pkg_resources, which is part of setuptools and not included by default in Python 3.12+.

ImportError while importing test module '/private/tmp/deprecated/tests/test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/importlib/__init__.py:90: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test.py:2: in <module>
    import pkg_resources
E   ModuleNotFoundError: No module named 'pkg_resources'

@hugovk
Copy link
Contributor Author

hugovk commented Oct 7, 2024

The failing Python 3.7 job is unrelated.

Python 3.7 is EOL, I recommend dropping support for it. (As it happens, Python 3.8 is also EOL today.)

Copy link
Owner

@laurent-laporte-pro laurent-laporte-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Can you make some small changes?

.github/workflows/python-package.yml Outdated Show resolved Hide resolved
.github/workflows/python-package.yml Outdated Show resolved Hide resolved
Copy link
Owner

@laurent-laporte-pro laurent-laporte-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recently add some commits in the master branch. Can you pull my changes and rebase on it? Thanks

@hugovk
Copy link
Contributor Author

hugovk commented Nov 15, 2024

Updated!

@laurent-laporte-pro laurent-laporte-pro merged commit abcb4e9 into laurent-laporte-pro:master Nov 15, 2024
19 checks passed
laurent-laporte-pro added a commit that referenced this pull request Nov 15, 2024
@laurent-laporte-pro laurent-laporte-pro mentioned this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants