Skip to content

Commit

Permalink
chore: remove bogo sort
Browse files Browse the repository at this point in the history
  • Loading branch information
@mavi0
mavi0 authored Nov 18, 2024
1 parent 411a684 commit e8aed63
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion web/priv/js_effects/sorting.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ return class MyEffect {
'cocktailShakerSort',
'gnomeSort',
'bitonicSort',
'bogoSort',
// 'bogoSort',
];
this.ROYGBIV = [
[255, 0, 0], // Red
Expand Down

3 comments on commit e8aed63

@mavi0
Copy link
Collaborator Author

@mavi0 mavi0 commented on e8aed63 Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out bogo sort @Orlando-PB - we have to be careful what we display at night as (cool as it looks!) this is an epilepsy risk. Image

@456dev
Copy link
Contributor

@456dev 456dev commented on e8aed63 Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mavi0 i suspect bogosort still isnt disabled, as

infolab-lights/web/priv/js_effects/sorting.js

Line 96 in e8aed63

return Math.random() < 0.01 ? 'bogoSort' : this.getRandomAlgorithm(); // set to 1 to get guaranteed bogoSort
causes it to not be pulled from the list of all algorithms, but by name instead.

@mavi0
Copy link
Collaborator Author

@mavi0 mavi0 commented on e8aed63 Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot @456dev! Should be fixed with 539b09b

Please sign in to comment.