-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: init action engine #1
Conversation
kaioken
commented
Jul 12, 2021
- Add Action Engine RFC
First a general observation: example: vuejs/rfcs#370 vuejs/rfcs#367.
From the information provided may be: "The purpose of the action engine is to generate an action page that collects information from leads and will trigger actions when this information is submitted back to our system, this will execute a set of workflows that send the result to any # of third parties, resulting in a historical feed of all the different actions the user has made over time." In the entities, it looks good but there's a point:
May need a little re-word in the RFC to give a clearer summary of what it does is not as clear as the others without seeing the DataBase Structure. Missed some details to filter better comments.
|
@jesusantguerrero thanks for the feedback will make the adjustments and add the missing details. And what I'm trying to get from the frontend team is to look at the overall structure for how we plan to handle the action engine to see if they see anything missing or can cause issues from your end thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice RFC, here are my thought's/questions:
-
In the db, the action_systems has a subsystem, can you give a specific example of why this is needed?
-
Need a more specific example about the difference between the action_type and the action_system, my understanding is that the action_system holds the domain logic and the type indicate which mode the action will be, but it's not clear why the type is independent of the action_system.
-
Is there a concrete case why an action_system have a subsystem?
-
Need more information about recievers, we haven't worked a lot with this entity.
-
I think action_data_type should be bound to an specific action_domain and action_type instead of a action. For example if I have dealer-content this is a information action that holds media content, this types are bound to the system (information) and the type (content). Also a action can hold different types.
-
Need a concrete example of the db structure implementation, let's take finance-products and credit-app and create what it would look like with that db structure.
-
Later (I know this is an initial RFC), we should work more in how are going to manage the action content.
-
We need another entity to bound landings in the web with actions so we can dynamically display specific content with different layouts.
@larizzatg will reply to those question today ;) |
To return the action list to UI mobile the engine must to acomplish with the next structure: [{
screenName:'dac.ContentPreview',
title: 'Dealer Content',
key: 'dealer-content',
reasonEn: 'learn more about our current offers',
reasonEs: 'aprender más sobre nuestras ofertas actuales',
attributes:{}
}] |
Update the RFC with a db example |
I think it looks good and clear. Obviously there's things I will not understand very well unless I see the more specific integration with frontend, but I get the big picture. I made a little change to the page flow diagram, I think it will be a little bit more clear like this, what do you think? |
@juanpichvrdo thanks will make those ajustments |