Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding simple unit test presubmit and unit test periodic #33987

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adding simple unit test presubmit and unit test periodic #33987

wants to merge 3 commits into from
+71 −0

Conversation

kfswain
Copy link
Contributor

@kfswain kfswain commented Dec 17, 2024

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kfswain
Once this PR has been reviewed and has the lgtm label, please assign priyankasaggu11929 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs labels Dec 17, 2024
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Dec 17, 2024
kannon92
kannon92 reviewed Dec 18, 2024
View reviewed changes
...jobs/kubernetes-sigs/gateway-api-inference-extension/inference-extension-periodics-main.yaml Outdated
base_ref: main
path_alias: sigs.k8s.io/gateway-api-inference-extension
annotations:
testgrid-dashboards: sig-apps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this sig-networking or sig-apps? This should be the owning sig for the repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sig net. Thanks for this! I moved it under gateway-api's dash.

@kannon92
Copy link
Contributor

/lgtm
/assign @dims @cblecker

This should get an OWNER File so the team can approve these without top-level approvers. Still then we could use your powers!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2024
@ahg-g
Copy link
Member

ahg-g commented Dec 18, 2024

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannon92 kannon92 kannon92 left review comments

@MadhavJivrajani MadhavJivrajani Awaiting requested review from MadhavJivrajani

@Priyankasaggu11929 Priyankasaggu11929 Awaiting requested review from Priyankasaggu11929

Assignees

@dims dims

@cblecker cblecker

@kannon92 kannon92

@ahg-g ahg-g

Labels
area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kfswain @k8s-ci-robot @kannon92 @ahg-g @dims @cblecker