-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRA focus regex replace --label-filter #33934
base: master
Are you sure you want to change the base?
DRA focus regex replace --label-filter #33934
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elieser1101 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @elieser1101. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
cc: @kannon92 |
I don't know. How does kubetest2 pass Ginkgo labels? |
If that's true, then falling back to |
someone want to add it ? it seems it should go here https://github.com/kubernetes-sigs/kubetest2/blob/b64611bb4b03aab9dd9025a61a84385fec6fa557/pkg/testers/ginkgo/ginkgo.go#L44 |
Sounds good, I’ll work on the kubetest2 fix |
Seem like the
--label-filter
is not available in kubetest2, and DRA test are not fully running.Used focus regex to replace it
part of #32567