Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create publishing-bot issue only for rc.0 release #3849

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Dec 4, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

The publishing-bot reminder issue is supposed to be created only when we cut the rc.0 release. At the moment, it's created for any pre-release rc release, i.e. *.0-rc.*.

e.g. kubernetes/sig-release#2674 is a duplicate of kubernetes/sig-release#2669

The logic in this PR has been based on

if len(tagVersion.Pre) == 2 && //nolint:gocritic // a switch case would not make it better
tagVersion.Pre[0].String() == "alpha" &&
tagVersion.Pre[1].VersionNum == 1 {
startTag = util.SemverToTagString(semver.Version{
Major: tagVersion.Major, Minor: tagVersion.Minor - 1, Patch: 0,
})
tagChoice = "previous minor version"

Does this PR introduce a user-facing change?

Create the publishing-bot reminder issue only when cutting `*.0-rc.0` release

/assign @saschagrunert @cpanato @puerco @Verolop
cc @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 4, 2024
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 4, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 4, 2024
@k8s-ci-robot k8s-ci-robot requested a review from jimangel December 4, 2024 18:24
@k8s-ci-robot k8s-ci-robot requested a review from jrsapi December 4, 2024 18:24
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 4, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2262891 into kubernetes:master Dec 4, 2024
11 checks passed
@xmudrii xmudrii deleted the pubbot-issue-rc.0 branch December 4, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants