Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Artifact Registry to Image Manifests - Part Eight #4308

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Add Artifact Registry to Image Manifests - Part Eight #4308

merged 1 commit into from
Oct 6, 2022

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Oct 4, 2022

Part of #3976
Fixes #1343

/cc @kubernetes/release-engineering @dims @BenTheElder

This is the last one. Merging this and the other PRs should complete the GCR to Artifact Registry(AR) Migration from sig-release's perspective. The last activity for sig-k8s-infra is to update oci-proxy/registry.k8s.io to serve images from AR and delete the jobs from kubernetes/test-infra#26916

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 4, 2022
upodroid
upodroid commented Oct 4, 2022
View reviewed changes
k8s.gcr.io/manifests/k8s-staging-test-infra/promoter-manifest.yaml
- name: eu.gcr.io/k8s-test-infra
service-account: [email protected]
- name: asia.gcr.io/k8s-test-infra
service-account: [email protected]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This manifest was promoting to a non-existent destination. @BenTheElder, are you happy with the rename?

 REDACTED  MCW0CDP3YY  tmp  test  $  gcrane ls us.gcr.io/k8s-test-infra
2022/10/04 20:03:09 No matching credentials were found for "us.gcr.io"
Error: GET https://us.gcr.io/v2/token?scope=repository%3Ak8s-test-infra%3Apull&service=us.gcr.io: UNKNOWN: Project 'project:k8s-test-infra' not found or deleted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@upodroid this should be k8s-infra-kubernetes-io perhaps?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it needs to be *.gcr.io/k8s-artifacts-prod/*/foobar

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these images are not being promoted currently, only pushed to gcr.io/k8s-staging-test-infra

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, there are others as well.

https://github.com/kubernetes/k8s.io/tree/main/k8s.gcr.io#creating-staging-repos these instructions need to be reconsidered. Everyone is following them even if they don't intend on promoting images from staging.

Copy link
Member

@BenTheElder BenTheElder Oct 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I think this name is fine, and we can tweak it later if we go to promote anything.
EDIT: also surfacing in #sig-testing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 test-infra

BenTheElder
BenTheElder reviewed Oct 5, 2022
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2022
spiffxp
spiffxp approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

remove /hold when you're ready for this to merge

k8s.gcr.io/manifests/k8s-staging-test-infra/promoter-manifest.yaml
- name: eu.gcr.io/k8s-test-infra
service-account: [email protected]
- name: asia.gcr.io/k8s-test-infra
service-account: [email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 test-infra

k8s.gcr.io/manifests/README.md
@@ -10,9 +10,35 @@ change.

Reviewers should ensure that:
* The source registry is one that we trust.
* There is one non-source registry for each of {us, eu, asia}.
* The non-source registries include an appropriate "subdir" for the
* The following destination registries must be specified:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like something a presubmit test should do for us to reduce review burden?

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, saschagrunert, spiffxp, upodroid, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@upodroid
Copy link
Member Author

upodroid commented Oct 6, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8a506f0 into kubernetes:main Oct 6, 2022
@upodroid upodroid mentioned this pull request Oct 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@xmudrii xmudrii xmudrii approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@spiffxp spiffxp spiffxp approved these changes

@dims dims Awaiting requested review from dims

Assignees

@spiffxp spiffxp

@saschagrunert saschagrunert

@BenTheElder BenTheElder

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GCR to Artifact Registry tracking
7 participants
@upodroid @k8s-ci-robot @dims @spiffxp @saschagrunert @BenTheElder @xmudrii