Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[octavia-ingress-controller] Pass revision_id when assigning/removing SGs #2631

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[octavia-ingress-controller] Pass revision_id when assigning/removing SGs #2631

wants to merge 1 commit into from

Conversation

stephenfin
Copy link
Member

What this PR does / why we need it:

Set revision ID when adding/removing security groups from a port.

Which issue this PR fixes(if applicable):

Fixes #2630

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign anguslees for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 19, 2024
@stephenfin
Copy link
Member Author

/retitle [octavia-ingress-controller] Pass revision_id when assigning/removing SGs

@k8s-ci-robot k8s-ci-robot changed the title Pass revision_id when assigning/removing SGs [octavia-ingress-controller] Pass revision_id when assigning/removing SGs Aug 19, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 19, 2024
@jichenjc
Copy link
Contributor

/test openstack-cloud-controller-manager-ovn-e2e-test

dulek
dulek reviewed Aug 28, 2024
View reviewed changes
pkg/openstack/loadbalancer_sg.go
newSGs := append(port.SecurityGroups, sg)
updateOpts := neutronports.UpdateOpts{SecurityGroups: &newSGs}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the intended retry logic here? I guess relying on controller backoff is fine, maybe just worth a different error message, but for reference: https://github.com/openshift/cloud-network-config-controller/blob/master/pkg/cloudprovider/openstack.go#L765-L809

@kayrus
Copy link
Contributor

kayrus commented Sep 17, 2024

/test openstack-cloud-controller-manager-e2e-test

@kayrus
Copy link
Contributor

kayrus commented Sep 17, 2024

/test openstack-cloud-controller-manager-ovn-e2e-test

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 16, 2024
@stephenfin
Copy link
Member Author

/remove-lifecycle stale
/hold

I'll pick this up again and address comments in the new year.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dulek dulek dulek left review comments

@anguslees anguslees Awaiting requested review from anguslees

@FengyunPan2 FengyunPan2 Awaiting requested review from FengyunPan2

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[octavia-ingress-controller] Possible lost update race conditions in adding and removing SGs
6 participants
@stephenfin @k8s-ci-robot @jichenjc @kayrus @k8s-triage-robot @dulek