Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix topology-updater cpu report #1979

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AllenXu93
Copy link

Fix #1978

Copy link

linux-foundation-easycla bot commented Dec 13, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AllenXu93
Once this PR has been reviewed and has the lgtm label, please assign marquiz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 13, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @AllenXu93!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 13, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @AllenXu93. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 13, 2024
Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit a694d91
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/675bdf26106a880008b3f942
😎 Deploy Preview https://deploy-preview-1979--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AllenXu93 AllenXu93 force-pushed the bugfix/fix-topology-updater-cpu branch from 15fda0b to 109cb7c Compare December 13, 2024 06:51
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 13, 2024
@AllenXu93 AllenXu93 force-pushed the bugfix/fix-topology-updater-cpu branch from 109cb7c to a694d91 Compare December 13, 2024 07:15
@ffromani
Copy link
Contributor

/cc

Need to review the code before to comment :)
While I get again up to speed, do we have test coverage for this change? can we use more unit/e2e tests?

@ffromani
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 16, 2024
@k8s-ci-robot
Copy link
Contributor

@AllenXu93: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-node-feature-discovery-verify-master a694d91 link true /test pull-node-feature-discovery-verify-master
pull-node-feature-discovery-build-image-cross-generic a694d91 link true /test pull-node-feature-discovery-build-image-cross-generic

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@marquiz
Copy link
Contributor

marquiz commented Dec 17, 2024

While I get again up to speed, do we have test coverage for this change? can we use more unit/e2e tests?

We seem to have some as the tests failed. But yes, we should have specific test case for this scenario-

@AllenXu93 could you fix and update the tests?

@AllenXu93
Copy link
Author

While I get again up to speed, do we have test coverage for this change? can we use more unit/e2e tests?

We seem to have some as the tests failed. But yes, we should have specific test case for this scenario-

@AllenXu93 could you fix and update the tests?

ok I will fix in this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nfd-topology-updater missed some cpu for Guaranteed pods
4 participants