-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
topology-updater: Track new resources not present during startup #1897
base: master
Are you sure you want to change the base?
Conversation
Hi @ozhuraki. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ozhuraki The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Could you please take a look if this is a right place to track new resources? |
I don't think that's the right place to fix it as later call to |
001c2e7
to
230fc67
Compare
Thanks for the help. I checked more, would something like this account for updateAvailable()? |
Signed-off-by: Oleg Zhurakivskyy <[email protected]>
230fc67
to
0c8a8fa
Compare
Apologies for a delay. Thanks, updated, could you please take another look? |
If a device plugin registers itself with kubelet after NFD topology-updater is already running the NRT will never be updated with new resources.
Closes: #1424