Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Gateway API CRDs install support #11376

Merged

Conversation

tico88612
Copy link
Member

@tico88612 tico88612 commented Jul 12, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Gateway API is now officially available and can be integrated into Kubespray.

Which issue(s) this PR fixes:

Related #10814

Special notes for your reviewer:
I verify this installation later. (UPD: verified.)

Does this PR introduce a user-facing change?:

Support Gateway API CRDs install

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 12, 2024
@k8s-ci-robot k8s-ci-robot requested review from mzaian and VannTen July 12, 2024 13:22
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 12, 2024
@tico88612 tico88612 force-pushed the feat/gateway-api-support branch 2 times, most recently from 4c2ddb4 to dd4bd31 Compare July 13, 2024 07:54
@yankay
Copy link
Member

yankay commented Jul 15, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 15, 2024
@tico88612
Copy link
Member Author

/retest-failed

@tico88612 tico88612 force-pushed the feat/gateway-api-support branch from dd4bd31 to 9667a71 Compare July 15, 2024 11:12
@tico88612 tico88612 force-pushed the feat/gateway-api-support branch from 9667a71 to bd069e2 Compare August 7, 2024 17:27
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 7, 2024
@tico88612
Copy link
Member Author

@yankay I already support offline installation of the Gateway API, PTAL.

@yankay
Copy link
Member

yankay commented Aug 29, 2024

Thanks @tico88612
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2024
@yankay
Copy link
Member

yankay commented Aug 30, 2024

HI @mzaian @VannTen
Would you please help to review it :-)

Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mzaian, tico88612, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8a961a6 into kubernetes-sigs:master Aug 31, 2024
39 checks passed
@tico88612 tico88612 deleted the feat/gateway-api-support branch August 31, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants