Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add kubetest files for upstream e2e tests #2417

Merged
merged 1 commit into from
Oct 31, 2023
Merged

🌱 Add kubetest files for upstream e2e tests #2417

merged 1 commit into from
Oct 31, 2023

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented Oct 9, 2023 •
edited
Loading

Adds kubetest yaml files for #2452

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 9, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 9, 2023
@chrischdi
Copy link
Member Author

/test help

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-vsphere-conformance-main
  • /test pull-cluster-api-provider-vsphere-e2e-full-main
  • /test pull-cluster-api-provider-vsphere-e2e-main
  • /test pull-cluster-api-provider-vsphere-test-integration-main
  • /test pull-cluster-api-provider-vsphere-test-main
  • /test pull-cluster-api-provider-vsphere-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-vsphere-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-vsphere-apidiff-main
  • pull-cluster-api-provider-vsphere-e2e-main
  • pull-cluster-api-provider-vsphere-test-integration-main
  • pull-cluster-api-provider-vsphere-test-main
  • pull-cluster-api-provider-vsphere-verify-main

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-conformance-main

@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c2b813c) 62.86% compared to head (afa2d3b) 63.73%.
Report is 28 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2417      +/-   ##
==========================================
+ Coverage   62.86%   63.73%   +0.87%     
==========================================
  Files         122      122              
  Lines        8770     8753      -17     
==========================================
+ Hits         5513     5579      +66     
+ Misses       2864     2767      -97     
- Partials      393      407      +14

see 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 9, 2023 •
edited
Loading

@chrischdi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-vsphere-conformance-main a762bfd link true /test pull-cluster-api-provider-vsphere-conformance-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chrischdi chrischdi force-pushed the pr-test-serial-tests branch from a762bfd to 926ea2d Compare October 19, 2023 14:45
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2023
@chrischdi chrischdi changed the title 🌱 [WIP][DNR] Test serial conformance tests 🌱 [WIP][DNR] POC upstream e2e tests Oct 19, 2023
@chrischdi chrischdi changed the title 🌱 [WIP][DNR] POC upstream e2e tests 🌱 Add kubetest files for upstream e2e tests Oct 20, 2023
This was referenced Oct 20, 2023
Open
Merged
@chrischdi
Copy link
Member Author

/assign @sbueringer @killianmuldoon

@chrischdi
Copy link
Member Author

One observation: ubuntu package nfs-common is missing for some tests to succeed.

killianmuldoon
killianmuldoon reviewed Oct 23, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

One Q: Do we have a reference for these configs - are they cloned from somewhere else?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 28e441c547879dd9338afce41941a117d2aceaa9

@chrischdi chrischdi force-pushed the pr-test-serial-tests branch from 926ea2d to afa2d3b Compare October 27, 2023 10:51
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 27, 2023
@chrischdi
Copy link
Member Author

/lgtm

One Q: Do we have a reference for these configs - are they cloned from somewhere else?

added a reference link.

killianmuldoon
killianmuldoon reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refs!

/lgtm
/approve

/hold
(not sure when you want to merge)

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8a154309a928910c840dcf848fd9ecb78f892b53

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2023
@chrischdi
Copy link
Member Author

Thanks for the hold. Currently running it in a test environment, and I will then compare the properties in the junit tests with the upstream tests, to ensure we use the very same configuration.

@chrischdi
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2023
@chrischdi
Copy link
Member Author

/hold cancel

one more thing

@k8s-ci-robot k8s-ci-robot merged commit f60e3c6 into kubernetes-sigs:main Oct 31, 2023
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Oct 31, 2023
@chrischdi chrischdi deleted the pr-test-serial-tests branch October 31, 2023 11:14
@chrischdi
Copy link
Member Author

ah damn :D wanted to hold again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
4 participants
@chrischdi @k8s-ci-robot @killianmuldoon @sbueringer