Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update pause-win image to the new one k8s.gcr.io/pause:3.4.1 #508

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Feb 9, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

As part of the efforts described in this Issue: kubernetes/k8s.io#1525 we are trying to move away from gcp project gke-release

Also the pause image was release with windows support as we can see in the merged or in k/k kubernetes/kubernetes#98205

/assign @spiffxp @feiskyer

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 9, 2021
@cpanato
Copy link
Member Author

cpanato commented Feb 9, 2021

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 9, 2021
@spiffxp
Copy link
Member

spiffxp commented Feb 9, 2021

/sig cloud-provider
/provider azure
/sig windows
/wg k8s-infra
/cc @pacoxu @claudiubelu
FYI, since you've been involved with the pause image change

@k8s-ci-robot
Copy link
Contributor

@spiffxp: GitHub didn't allow me to request PR reviews from the following users: pacoxu.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/sig cloud-provider
/provider azure
/sig windows
/wg k8s-infra
/cc @pacoxu @claudiubelu
FYI, since you've been involved with the pause image change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/windows Categorizes an issue or PR as relevant to SIG Windows. wg/k8s-infra labels Feb 9, 2021
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2021
@spiffxp
Copy link
Member

spiffxp commented Feb 9, 2021

/assign @feiskyer @andyzhangx
for the /approve

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cpanato, pacoxu, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f8dd414 into kubernetes-sigs:master Feb 9, 2021
@cpanato cpanato deleted the K8sio-GH-1525 branch February 9, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants